Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3571)

Unified Diff: cc/layers/scrollbar_layer_impl.h

Issue 18341009: Refactor cc scrollbar layers to separate solid-color vs desktop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address tfarina@'s comments. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/scrollbar_layer_impl.h
diff --git a/cc/layers/scrollbar_layer_impl.h b/cc/layers/scrollbar_layer_impl.h
index dbbbe480e453fc014c7299deb10e7ef181d7b4de..71bbb0c54b9549ce86ed14f4a31199d1990bd669 100644
--- a/cc/layers/scrollbar_layer_impl.h
+++ b/cc/layers/scrollbar_layer_impl.h
@@ -7,14 +7,14 @@
#include "cc/base/cc_export.h"
#include "cc/input/scrollbar.h"
-#include "cc/layers/layer_impl.h"
+#include "cc/layers/scrollbar_layer_impl_base.h"
namespace cc {
class LayerTreeImpl;
class ScrollView;
-class CC_EXPORT ScrollbarLayerImpl : public LayerImpl {
+class CC_EXPORT ScrollbarLayerImpl : public ScrollbarLayerImplBase {
public:
static scoped_ptr<ScrollbarLayerImpl> Create(
LayerTreeImpl* tree_impl,
@@ -23,7 +23,6 @@ class CC_EXPORT ScrollbarLayerImpl : public LayerImpl {
virtual ~ScrollbarLayerImpl();
// LayerImpl implementation.
- virtual ScrollbarLayerImpl* ToScrollbarLayer() OVERRIDE;
virtual scoped_ptr<LayerImpl> CreateLayerImpl(LayerTreeImpl* tree_impl)
OVERRIDE;
virtual void PushPropertiesTo(LayerImpl* layer) OVERRIDE;
@@ -35,13 +34,6 @@ class CC_EXPORT ScrollbarLayerImpl : public LayerImpl {
virtual void DidLoseOutputSurface() OVERRIDE;
- int scroll_layer_id() const { return scroll_layer_id_; }
- void set_scroll_layer_id(int id) { scroll_layer_id_ = id; }
-
- ScrollbarOrientation Orientation() const;
- float CurrentPos() const;
- int Maximum() const;
-
void set_thumb_thickness(int thumb_thickness) {
thumb_thickness_ = thumb_thickness;
}
@@ -54,23 +46,14 @@ class CC_EXPORT ScrollbarLayerImpl : public LayerImpl {
void set_track_length(int track_length) {
track_length_ = track_length;
}
- void set_vertical_adjust(float vertical_adjust) {
- vertical_adjust_ = vertical_adjust;
- }
void set_track_resource_id(ResourceProvider::ResourceId id) {
track_resource_id_ = id;
}
void set_thumb_resource_id(ResourceProvider::ResourceId id) {
thumb_resource_id_ = id;
}
- void set_visible_to_total_length_ratio(float ratio) {
- visible_to_total_length_ratio_ = ratio;
- }
-
- void SetCurrentPos(float current_pos) { current_pos_ = current_pos; }
- void SetMaximum(int maximum) { maximum_ = maximum; }
- gfx::Rect ComputeThumbQuadRect() const;
+ virtual gfx::Rect ComputeThumbQuadRect() const OVERRIDE;
protected:
ScrollbarLayerImpl(LayerTreeImpl* tree_impl,
@@ -80,27 +63,15 @@ class CC_EXPORT ScrollbarLayerImpl : public LayerImpl {
private:
virtual const char* LayerTypeAsString() const OVERRIDE;
- gfx::Rect ScrollbarLayerRectToContentRect(gfx::RectF layer_rect) const;
-
ResourceProvider::ResourceId track_resource_id_;
ResourceProvider::ResourceId thumb_resource_id_;
- float current_pos_;
- int maximum_;
int thumb_thickness_;
int thumb_length_;
int track_start_;
int track_length_;
ScrollbarOrientation orientation_;
- // Difference between the clip layer's height and the visible viewport
- // height (which may differ in the presence of top-controls hiding).
- float vertical_adjust_;
-
- float visible_to_total_length_ratio_;
-
- int scroll_layer_id_;
-
bool is_scrollable_area_active_;
bool is_scroll_view_scrollbar_;
bool enabled_;

Powered by Google App Engine
This is Rietveld 408576698