Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1834093002: VM: Fix _CompactLinkedHashSet performance regression. (Closed)

Created:
4 years, 9 months ago by sra1
Modified:
4 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org, srdjan
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix _CompactLinkedHashSet performance regression. Directly initializing field helps the VM figure out that they cannot be null. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/83e73400dba98fc21c4ea58da1869a385efa669f

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M runtime/lib/compact_hash.dart View 1 5 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
Florian Schneider
LGTM
4 years, 9 months ago (2016-03-26 19:17:04 UTC) #4
sra1
4 years, 8 months ago (2016-03-28 14:44:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
83e73400dba98fc21c4ea58da1869a385efa669f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698