Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Issue 1834073002: [DevTools] Create agents on attach. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Create agents on attach. To support multiple attached devtools, we have to instantiate individual agents on demand, rather than on creation. This patch moves regular of agents, with view-specific and worker's left. BUG=590878 Committed: https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232 Cr-Commit-Position: refs/heads/master@{#383833}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -106 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 4 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 6 chunks +70 lines, -74 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dgozman
Take a look please.
4 years, 8 months ago (2016-03-26 02:24:22 UTC) #2
pfeldman
lgtm
4 years, 8 months ago (2016-03-28 17:55:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834073002/20001
4 years, 8 months ago (2016-03-29 18:14:11 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 21:33:40 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 21:34:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cd7f315c2510c49b8424f71e1e77daeddc28232
Cr-Commit-Position: refs/heads/master@{#383833}

Powered by Google App Engine
This is Rietveld 408576698