Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1834053002: Roll ICU to 3edd83a9 (Closed)

Created:
4 years, 9 months ago by jungshik at Google
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ICU to 3edd83a9 See https://chromium.googlesource.com/chromium/deps/icu.git/+log/0d572d65..3edd83a9 for details. BUG=598000 TEST=See bug comment 0 and comment 1 TBR=mark@chromium.org,droger@chromium.org Committed: https://crrev.com/7b2f0874cba77b457749e040fa056fb8ed4ad899 Cr-Commit-Position: refs/heads/master@{#383943}

Patch Set 1 #

Patch Set 2 : crnet fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ios/crnet/crnet_consumer/crnet_consumer.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
jungshik at Google
4 years, 9 months ago (2016-03-25 23:52:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834053002/1
4 years, 9 months ago (2016-03-25 23:53:36 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/191559)
4 years, 9 months ago (2016-03-26 00:01:23 UTC) #5
Mark Mentovai
LGTM
4 years, 9 months ago (2016-03-26 03:01:12 UTC) #6
jungshik at Google
Elly, can you approve CrNet portion of the CL? icudtl.dat's location was changed (source/data/in ==> ...
4 years, 9 months ago (2016-03-26 05:31:38 UTC) #7
jungshik at Google
ellyjones@chromium.org: Please review changes in crnet. It's just a path change (third_party/icu changed the location ...
4 years, 8 months ago (2016-03-28 17:45:12 UTC) #9
jungshik at Google
Because it's just a path change in third_party/icu, I'm TBR'ing with droger@.
4 years, 8 months ago (2016-03-30 07:13:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1834053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1834053002/20001
4 years, 8 months ago (2016-03-30 07:14:01 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 10:17:47 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7b2f0874cba77b457749e040fa056fb8ed4ad899 Cr-Commit-Position: refs/heads/master@{#383943}
4 years, 8 months ago (2016-03-30 10:19:10 UTC) #18
droger
4 years, 8 months ago (2016-03-31 08:10:20 UTC) #19
Message was sent while issue was closed.
lgtm
Thanks!

Powered by Google App Engine
This is Rietveld 408576698