Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1833983002: [ios] Switched web shell to use WebState for view and navigation. (Closed)

Created:
4 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 9 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Switched web shell to use WebState for view and navigation. - Use WebState::GetView() instead of -[CRWWebController view] - Use web::NavigationManager for navigation BUG=597997 Committed: https://crrev.com/c1b7e26ae910bd1496bd80f61b11f8f831e20c65 Cr-Commit-Position: refs/heads/master@{#383386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M ios/web/shell/view_controller.mm View 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Eugene But (OOO till 7-30)
4 years, 9 months ago (2016-03-25 21:46:26 UTC) #3
kkhorimoto
lgtm
4 years, 9 months ago (2016-03-25 21:53:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833983002/1
4 years, 9 months ago (2016-03-25 21:53:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 22:29:27 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 22:31:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1b7e26ae910bd1496bd80f61b11f8f831e20c65
Cr-Commit-Position: refs/heads/master@{#383386}

Powered by Google App Engine
This is Rietveld 408576698