Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1833933002: Remove kSwappedOutURL as it is now unused. (Closed)

Created:
4 years, 9 months ago by nasko
Modified:
4 years, 9 months ago
Reviewers:
Charlie Reis, sky
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove kSwappedOutURL as it is now unused. Since swapped out state on RenderFrameHost has been removed, there is no longer usage of kSwappedOutURL and the code can safely be removed. BUG=357747 Committed: https://crrev.com/53e2f800170d79b1d8279f545e24078ece58e4ff Cr-Commit-Position: refs/heads/master@{#383398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -45 lines) Patch
M chrome/renderer/content_settings_observer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/common/url_constants.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +3 lines, -23 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
nasko
Hey Charlie, An end of an area is here. Would you do the honours?! : ...
4 years, 9 months ago (2016-03-25 20:44:59 UTC) #2
Charlie Reis
So happy to approve this! LGTM.
4 years, 9 months ago (2016-03-25 20:49:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833933002/1
4 years, 9 months ago (2016-03-25 20:59:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/160904)
4 years, 9 months ago (2016-03-25 21:09:22 UTC) #8
nasko
Hey sky@, Can you do a chrome/ OWNERS stamp this CL for me? Thanks in ...
4 years, 9 months ago (2016-03-25 21:16:12 UTC) #10
sky
LGTM
4 years, 9 months ago (2016-03-25 22:59:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833933002/1
4 years, 9 months ago (2016-03-25 23:03:25 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 23:09:53 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 23:11:34 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53e2f800170d79b1d8279f545e24078ece58e4ff
Cr-Commit-Position: refs/heads/master@{#383398}

Powered by Google App Engine
This is Rietveld 408576698