Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1833903002: Fix regression in toolbar and bubble border drawing in Incognito (Mac). (Closed)

Created:
4 years, 9 months ago by shrike
Modified:
4 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix regression in toolbar and bubble border drawing in Incognito (Mac). Running with --incognito the toolbar border and some bubble borders were red. This was a result of an error in a Material Design change. BUG=597575 Committed: https://crrev.com/5b491b19b2a91811192c8201404eec8f7396f4d9 Cr-Commit-Position: refs/heads/master@{#383585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/themes/theme_properties.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
shrike
PTAL
4 years, 9 months ago (2016-03-25 17:53:15 UTC) #3
Evan Stade
lgtm
4 years, 8 months ago (2016-03-28 19:33:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833903002/1
4 years, 8 months ago (2016-03-28 21:32:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-28 22:39:40 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 22:41:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b491b19b2a91811192c8201404eec8f7396f4d9
Cr-Commit-Position: refs/heads/master@{#383585}

Powered by Google App Engine
This is Rietveld 408576698