chrome/browser/ui/sad_tab_helper.cc - Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sad_tab_helper.cc

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Mac compile error. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/sad_tab_helper.cc

diff --git a/chrome/browser/ui/sad_tab_helper.cc b/chrome/browser/ui/sad_tab_helper.cc

index 9d834a668b70de2aad7d31823b7d40b11d7e1405..dfcb1cfcb00280869a0ee42024afdb2c53d5d027 100644

--- a/chrome/browser/ui/sad_tab_helper.cc

+++ b/chrome/browser/ui/sad_tab_helper.cc

@@ -23,7 +23,7 @@ SadTabHelper::SadTabHelper(content::WebContents* web_contents)

content::Source<content::WebContents>(web_contents));

}

-void SadTabHelper::RenderViewGone(base::TerminationStatus status) {

+void SadTabHelper::RenderProcessGone(base::TerminationStatus status) {

// Only show the sad tab if we're not in browser shutdown, so that WebContents

// objects that are not in a browser (e.g., HTML dialogs) and thus are

// visible do not flash a sad tab page.