content/browser/web_contents/web_contents_impl.cc - Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 18339006: Rename RenderViewGone IPC/methods to better reflect reality (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixes for reviews by creis@ and palmer@. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 3842e88b139f06ea50223400abc9499d74ca93d7..a7b7031e7df192707e52325b65de3e1b5f2ebb02 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2886,7 +2886,7 @@ void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh,

FOR_EACH_OBSERVER(WebContentsObserver,

observers_,

- RenderViewGone(GetCrashedStatus()));

+ RenderProcessGone(GetCrashedStatus()));

}

void WebContentsImpl::RenderViewDeleted(RenderViewHost* rvh) {

@@ -3487,7 +3487,7 @@ void WebContentsImpl::BeforeUnloadFiredFromRenderManager(

// Note: |this| might be deleted at this point.

}

-void WebContentsImpl::RenderViewGoneFromRenderManager(

+void WebContentsImpl::RenderProcessGoneFromRenderManager(

RenderViewHost* render_view_host) {

DCHECK(crashed_status_ != base::TERMINATION_STATUS_STILL_RUNNING);

RenderViewTerminated(render_view_host, crashed_status_, crashed_error_code_);