process_policy_test.cc: Fix mixed-sign comparison warning.

process_policy_test.cc: Fix mixed-sign comparison warning.

Clang builds were failing like this:

In file included from ..\..\sandbox\win\src\process_policy_test.cc:19:
..\..\testing/gtest/include/gtest/gtest.h(1392,16):
error: comparison of integers of different signs: 'const unsigned long' and 'const int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\testing/gtest/include/gtest/gtest.h(1422,12):
note: in instantiation of function template specialization 'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
..\..\sandbox\win\src\process_policy_test.cc(419,3):
note: in instantiation of function template specialization 'testing::internal::EqHelper<false>::Compare<unsigned long, int>' requested here
  EXPECT_EQ(STATUS_BREAKPOINT, runner.RunTest(L"Process_Crash"));
  ^
..\..\testing/gtest/include/gtest/gtest.h(1928,67):  note: expanded from macro 'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
                                                                  ^

BUG=82385
TBR=wfh

Committed: https://chromium.googlesource.com/chromium/src/+/035459168ac247f089c25d5f5c3c1f36814bb1f5

[hans, 2016-03-25 16:08:23]

Description was changed from

==========
process_policy_test.cc: Fix mixed-sign comparison warning.

Clang builds were failing like this:

In file included from ..\..\sandbox\win\src\process_policy_test.cc:19:
..\..\testing/gtest/include/gtest/gtest.h(1392,16):
error: comparison of integers of different signs: 'const unsigned long' and
'const int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\testing/gtest/include/gtest/gtest.h(1422,12):
note: in instantiation of function template specialization
'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
..\..\sandbox\win\src\process_policy_test.cc(419,3):
note: in instantiation of function template specialization
'testing::internal::EqHelper<false>::Compare<unsigned long, int>' requested here
  EXPECT_EQ(STATUS_BREAKPOINT, runner.RunTest(L"Process_Crash"));
  ^
..\..\testing/gtest/include/gtest/gtest.h(1928,67):  note: expanded from macro
'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
                                                                  ^


BUG=82385
==========

to

==========
process_policy_test.cc: Fix mixed-sign comparison warning.

Clang builds were failing like this:

In file included from ..\..\sandbox\win\src\process_policy_test.cc:19:
..\..\testing/gtest/include/gtest/gtest.h(1392,16):
error: comparison of integers of different signs: 'const unsigned long' and
'const int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\testing/gtest/include/gtest/gtest.h(1422,12):
note: in instantiation of function template specialization
'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
..\..\sandbox\win\src\process_policy_test.cc(419,3):
note: in instantiation of function template specialization
'testing::internal::EqHelper<false>::Compare<unsigned long, int>' requested here
  EXPECT_EQ(STATUS_BREAKPOINT, runner.RunTest(L"Process_Crash"));
  ^
..\..\testing/gtest/include/gtest/gtest.h(1928,67):  note: expanded from macro
'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
                                                                  ^

BUG=82385
TBR=wfh
==========

[hans, 2016-03-25 16:08:23]

hans@chromium.org changed reviewers:
+ wfh@chromium.org

[hans, 2016-03-25 16:08:26]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2016-03-25 16:08:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1833863004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1833863004/1

[commit-bot: I haz the power, 2016-03-25 16:30:47]

Description was changed from

==========
process_policy_test.cc: Fix mixed-sign comparison warning.

Clang builds were failing like this:

In file included from ..\..\sandbox\win\src\process_policy_test.cc:19:
..\..\testing/gtest/include/gtest/gtest.h(1392,16):
error: comparison of integers of different signs: 'const unsigned long' and
'const int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\testing/gtest/include/gtest/gtest.h(1422,12):
note: in instantiation of function template specialization
'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
..\..\sandbox\win\src\process_policy_test.cc(419,3):
note: in instantiation of function template specialization
'testing::internal::EqHelper<false>::Compare<unsigned long, int>' requested here
  EXPECT_EQ(STATUS_BREAKPOINT, runner.RunTest(L"Process_Crash"));
  ^
..\..\testing/gtest/include/gtest/gtest.h(1928,67):  note: expanded from macro
'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
                                                                  ^

BUG=82385
TBR=wfh
==========

to

==========
process_policy_test.cc: Fix mixed-sign comparison warning.

Clang builds were failing like this:

In file included from ..\..\sandbox\win\src\process_policy_test.cc:19:
..\..\testing/gtest/include/gtest/gtest.h(1392,16):
error: comparison of integers of different signs: 'const unsigned long' and
'const int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\testing/gtest/include/gtest/gtest.h(1422,12):
note: in instantiation of function template specialization
'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
..\..\sandbox\win\src\process_policy_test.cc(419,3):
note: in instantiation of function template specialization
'testing::internal::EqHelper<false>::Compare<unsigned long, int>' requested here
  EXPECT_EQ(STATUS_BREAKPOINT, runner.RunTest(L"Process_Crash"));
  ^
..\..\testing/gtest/include/gtest/gtest.h(1928,67):  note: expanded from macro
'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
                                                                  ^

BUG=82385
TBR=wfh

Committed: https://crrev.com/035459168ac247f089c25d5f5c3c1f36814bb1f5
Cr-Commit-Position: refs/heads/master@{#383286}
==========

[commit-bot: I haz the power, 2016-03-25 16:30:48]

Patchset 1 (id:??) landed as
https://crrev.com/035459168ac247f089c25d5f5c3c1f36814bb1f5
Cr-Commit-Position: refs/heads/master@{#383286}

[hans, 2016-03-25 16:31:54]

Description was changed from

==========
process_policy_test.cc: Fix mixed-sign comparison warning.

Clang builds were failing like this:

In file included from ..\..\sandbox\win\src\process_policy_test.cc:19:
..\..\testing/gtest/include/gtest/gtest.h(1392,16):
error: comparison of integers of different signs: 'const unsigned long' and
'const int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\testing/gtest/include/gtest/gtest.h(1422,12):
note: in instantiation of function template specialization
'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
..\..\sandbox\win\src\process_policy_test.cc(419,3):
note: in instantiation of function template specialization
'testing::internal::EqHelper<false>::Compare<unsigned long, int>' requested here
  EXPECT_EQ(STATUS_BREAKPOINT, runner.RunTest(L"Process_Crash"));
  ^
..\..\testing/gtest/include/gtest/gtest.h(1928,67):  note: expanded from macro
'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
                                                                  ^

BUG=82385
TBR=wfh

Committed: https://crrev.com/035459168ac247f089c25d5f5c3c1f36814bb1f5
Cr-Commit-Position: refs/heads/master@{#383286}
==========

to

==========
process_policy_test.cc: Fix mixed-sign comparison warning.

Clang builds were failing like this:

In file included from ..\..\sandbox\win\src\process_policy_test.cc:19:
..\..\testing/gtest/include/gtest/gtest.h(1392,16):
error: comparison of integers of different signs: 'const unsigned long' and
'const int' [-Werror,-Wsign-compare]
  if (expected == actual) {
      ~~~~~~~~ ^  ~~~~~~
..\..\testing/gtest/include/gtest/gtest.h(1422,12):
note: in instantiation of function template specialization
'testing::internal::CmpHelperEQ<unsigned long, int>' requested here
    return CmpHelperEQ(expected_expression, actual_expression, expected,
           ^
..\..\sandbox\win\src\process_policy_test.cc(419,3):
note: in instantiation of function template specialization
'testing::internal::EqHelper<false>::Compare<unsigned long, int>' requested here
  EXPECT_EQ(STATUS_BREAKPOINT, runner.RunTest(L"Process_Crash"));
  ^
..\..\testing/gtest/include/gtest/gtest.h(1928,67):  note: expanded from macro
'EXPECT_EQ'
                      EqHelper<GTEST_IS_NULL_LITERAL_(expected)>::Compare, \
                                                                  ^

BUG=82385
TBR=wfh

Committed:
https://chromium.googlesource.com/chromium/src/+/035459168ac247f089c25d5f5c3c...
==========

[hans, 2016-03-25 16:31:55]

Committed patchset #1 (id:1) manually as
035459168ac247f089c25d5f5c3c1f36814bb1f5 (presubmit successful).

[Will Harris, 2016-03-25 16:41:55]

lgtm. when will clang compiler bots be coming to the CQ? :)

[hans, 2016-03-25 17:48:57]

On 2016/03/25 16:41:55, Will Harris wrote:
> lgtm. when will clang compiler bots be coming to the CQ? :)

Should be Real Soon Now. Nico enabled it earlier this week, but had to disable
again due to capacity issues.