Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Unified Diff: Tools/Scripts/webkitpy/tool/servers/gardeningserver.py

Issue 183383008: Garden-o-matic: Fix rebaseline-json results handling (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix formatting Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
diff --git a/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py b/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
index 8bc38cd38d9d9ace9717b06c521786dbd06acc90..53c636565f65bd0e01b62dccc0ecda35979b2eb5 100644
--- a/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
+++ b/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
@@ -112,13 +112,14 @@ class GardeningHTTPRequestHandler(ReflectionHandler):
_log.debug("calling %s, input='%s'", command, json_input)
return_code, output, error = self._run_webkit_patch(command, json_input)
print >> sys.stderr, error
+ json_result = {"return_code": return_code}
if return_code:
_log.error("rebaseline-json failed: %d, output='%s'" % (return_code, output))
+ json_result["output"] = output
else:
_log.debug("rebaseline-json succeeded")
- # FIXME: propagate error and/or log messages back to the UI.
- self._serve_text('success')
+ self._serve_text(json.dumps(json_result))
def localresult(self):
path = self.query['path'][0]
« no previous file with comments | « Tools/GardeningServer/scripts/controllers.js ('k') | Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698