Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: Tools/GardeningServer/scripts/controllers.js

Issue 183383008: Garden-o-matic: Fix rebaseline-json results handling (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix formatting Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/scripts/checkout.js ('k') | Tools/Scripts/webkitpy/tool/servers/gardeningserver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/scripts/controllers.js
diff --git a/Tools/GardeningServer/scripts/controllers.js b/Tools/GardeningServer/scripts/controllers.js
index e73464e8cfa12e062b3cce3c15a179f28f496aa3..e294a0cea6097bae39b86ab38a09beae043a171f 100644
--- a/Tools/GardeningServer/scripts/controllers.js
+++ b/Tools/GardeningServer/scripts/controllers.js
@@ -53,8 +53,19 @@ function rebaselineWithStatusUpdates(failureInfoList, resultsByTest)
});
if (failuresToRebaseline.length) {
- checkout.rebaseline(failuresToRebaseline, function() {
- statusView.addFinalMessage(id, 'Rebaseline done! Please land with "webkit-patch land-cowhand".');
+ // FIXME: checkout.rebaseline() accepts only 3 arguments, we pass 5.
+ checkout.rebaseline(failuresToRebaseline, function(response) {
+ try {
+ var json = JSON.parse(response);
+ if (!json.result_code) {
+ statusView.addFinalMessage(id, 'Rebaseline done! Please commit locally and land with "git cl dcommit".');
+ } else {
+ statusView.addMessage(id, 'Rebaseline failed (code=' + json.result_code + ')!');
+ statusView.addFinalMessage(id, json.output);
+ }
+ } catch (e) {
+ statusView.addFinalMessage(id, 'Invalid response received: "' + response + '"');
+ }
}, function(failureInfo) {
statusView.addMessage(id, failureInfo.testName + ' on ' + ui.displayNameForBuilder(failureInfo.builderName));
}, function() {
@@ -88,7 +99,7 @@ function updateExpectationsWithStatusUpdates(failureInfoList)
statusView.addMessage(id, 'Updating expectations of ' + testName + '...');
checkout.updateExpectations(failureInfoList, function() {
- statusView.addFinalMessage(id, 'Expectations update done! Please land with "webkit-patch land-cowhand".');
+ statusView.addFinalMessage(id, 'Expectations update done! Please commit them locally and land with "git cl dcommit".');
}, function() {
statusView.addFinalMessage(id, kCheckoutUnavailableMessage);
});
« no previous file with comments | « Tools/GardeningServer/scripts/checkout.js ('k') | Tools/Scripts/webkitpy/tool/servers/gardeningserver.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698