Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 183383008: Garden-o-matic: Fix rebaseline-json results handling (Closed)

Created:
6 years, 9 months ago by apavlov
Modified:
6 years, 9 months ago
Reviewers:
dglazkov, eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Garden-o-matic: Fix rebaseline-json results handling The rebaseline-json results are returned as a JSON object with |return_code| and optional error |output| fields. R=eseidel,dglazkov@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168446

Patch Set 1 #

Patch Set 2 : Restore dropped _log.debug() call #

Patch Set 3 : Add error output into its own message #

Patch Set 4 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M Tools/GardeningServer/scripts/checkout.js View 1 chunk +1 line, -1 line 0 comments Download
M Tools/GardeningServer/scripts/controllers.js View 1 2 3 2 chunks +14 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/servers/gardeningserver.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
apavlov
6 years, 9 months ago (2014-03-04 10:41:28 UTC) #1
dglazkov
lgtm
6 years, 9 months ago (2014-03-04 17:25:55 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-04 18:39:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/183383008/20001
6 years, 9 months ago (2014-03-04 18:39:35 UTC) #4
apavlov
The CQ bit was unchecked by apavlov@chromium.org
6 years, 9 months ago (2014-03-05 06:59:54 UTC) #5
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-05 06:59:57 UTC) #6
apavlov
The CQ bit was unchecked by apavlov@chromium.org
6 years, 9 months ago (2014-03-05 07:16:02 UTC) #7
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-05 07:16:37 UTC) #8
apavlov
The CQ bit was unchecked by apavlov@chromium.org
6 years, 9 months ago (2014-03-05 07:17:38 UTC) #9
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 9 months ago (2014-03-05 07:58:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/183383008/60001
6 years, 9 months ago (2014-03-05 07:58:33 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 08:00:05 UTC) #12
Message was sent while issue was closed.
Change committed as 168446

Powered by Google App Engine
This is Rietveld 408576698