Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/debug/trace_event_win_unittest.cc

Issue 18338004: Don't use StaticMemorySingletonTraits for TraceLog. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: use LeakySingletonTraits as TraceLog is used on non-joinable threads Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/debug/trace_event_unittest.cc ('K') | « base/debug/trace_event_unittest.cc ('k') | base/test/trace_event_analyzer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/trace_event_win_unittest.cc
===================================================================
--- base/debug/trace_event_win_unittest.cc (revision 210376)
+++ base/debug/trace_event_win_unittest.cc (working copy)
@@ -158,6 +158,9 @@
if (!log_file_.value().empty())
base::Delete(log_file_, false);
+
+ // We want our singleton torn down after each test.
+ TraceLog::DeleteForTesting();
}
void ExpectEvent(REFGUID guid,
« base/debug/trace_event_unittest.cc ('K') | « base/debug/trace_event_unittest.cc ('k') | base/test/trace_event_analyzer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698