Don't use StaticMemorySingletonTraits for TraceLog.

Don't use StaticMemorySingletonTraits for TraceLog.

Let's try this out as it's not clear to me that the extra complexity is needed. If code in the field is using this object at shutdown after the exit manager has destructed, then there'll be null dereferences now anyways. Also, we shouldn't have C++ static objects as they should all be using Singleton.

BUG=258047
R=nduca@chromium.org, scheib@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210446

[scheib, 2013-07-08 22:58:57]

lgtm

https://codereview.chromium.org/18338004/diff/7003/base/debug/trace_event_uni...
File base/debug/trace_event_unittest.cc (left):

https://codereview.chromium.org/18338004/diff/7003/base/debug/trace_event_uni...
base/debug/trace_event_unittest.cc:1524: // Test trace calls made after tracing
singleton shut down.
I was initially hesitant to remove this test- but in conversation agree that
with TraceLog being a normal singleton there is no need to test for different
behavior of calls made after the singleton is removed. New categories will
perform a null check after TraceLog::GetInstance in GetCategoryGroupEnabled.
Existing categories will be looked up and be false.

however, since we're removing this we can also change ManualTestSetUp to just
SetUp and remove calls to it in this file.

[jam, 2013-07-08 23:03:10]

nduca: ptal, Vincent wanted to get your thoughts on this as well

https://codereview.chromium.org/18338004/diff/7003/base/debug/trace_event_uni...
File base/debug/trace_event_unittest.cc (left):

https://codereview.chromium.org/18338004/diff/7003/base/debug/trace_event_uni...
base/debug/trace_event_unittest.cc:1524: // Test trace calls made after tracing
singleton shut down.
On 2013/07/08 22:58:57, scheib wrote:
> I was initially hesitant to remove this test- but in conversation agree that
> with TraceLog being a normal singleton there is no need to test for different
> behavior of calls made after the singleton is removed. New categories will
> perform a null check after TraceLog::GetInstance in GetCategoryGroupEnabled.
> Existing categories will be looked up and be false.
> 
> however, since we're removing this we can also change ManualTestSetUp to just
> SetUp and remove calls to it in this file.

Done.

[nduca, 2013-07-08 23:09:05]

fine by me, lgtm