Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1833793002: SkPDF: speed up SkPDFShader generation. (Closed)

Created:
4 years, 9 months ago by hal.canary
Modified:
4 years, 9 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: speed up SkPDFShader generation. Stop using SkString::append() when SkDynamicMemoryWStream works better. Also add a bench to prove that this speeds things up: before: micros bench 59.33 ? PDFShader nonrendering after: micros bench 34.55 ? PDFShader nonrendering GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1833793002 Committed: https://skia.googlesource.com/skia/+/d11c7268a2a4303e842f4ba16da98fcd0a2b7555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -152 lines) Patch
M bench/PDFBench.cpp View 2 chunks +31 lines, -0 lines 0 comments Download
M src/pdf/SkPDFDocument.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 16 chunks +154 lines, -152 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hal.canary
ptal
4 years, 9 months ago (2016-03-24 22:24:44 UTC) #3
caryclark
lgtm
4 years, 9 months ago (2016-03-25 12:15:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833793002/1
4 years, 9 months ago (2016-03-25 12:38:42 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 12:53:01 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d11c7268a2a4303e842f4ba16da98fcd0a2b7555

Powered by Google App Engine
This is Rietveld 408576698