chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h - Issue 1833773002: [Extensions] Convert APIs to use movable types [8]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h

Issue 1833773002: [Extensions] Convert APIs to use movable types [8] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h

index 56ff2d83e9f26eb09978dea4e627e7cfe8358712..4923470ad77bf16d0d05c66cc454132f820758e0 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h

@@ -39,8 +39,9 @@ class PasswordsPrivateEventRouter :

void OnListenerRemoved(const EventListenerInfo& details) override;

// PasswordsPrivateDelegate::Observer overrides:

- void OnSavedPasswordsListChanged(const std::vector<linked_ptr<

- api::passwords_private::PasswordUiEntry>>& entries) override;

+ void OnSavedPasswordsListChanged(

+ const std::vector<api::passwords_private::PasswordUiEntry>& entries)

+ override;

void OnPasswordExceptionsListChanged(

const std::vector<std::string>& exceptions) override;

void OnPlaintextPasswordFetched(

@@ -69,6 +70,9 @@ class PasswordsPrivateEventRouter :

// Whether this class is currently listening for changes to password changes.

bool listening_;

+ // True if we should ignore an update from PasswordsPrivateDelegate.

+ bool ignore_updates_;

DISALLOW_COPY_AND_ASSIGN(PasswordsPrivateEventRouter);

};