chrome/browser/android/ntp/ntp_snippets_bridge.h - Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.h

Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address more comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/ntp/ntp_snippets_bridge.h

diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.h b/chrome/browser/android/ntp/ntp_snippets_bridge.h

index d013f53e4c2ba39f436b0eb02877b05f9ed7f6a7..79c562caf6874472949ca9770a8dd28fc0a544db 100644

--- a/chrome/browser/android/ntp/ntp_snippets_bridge.h

+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.h

@@ -11,7 +11,7 @@

#include "base/scoped_observer.h"

#include "components/ntp_snippets/ntp_snippets_service.h"

-// The C++ counterpart to NTPSnippetsBridge.java. Enables Java code to access

+// The C++ counterpart to SnippetsBridge.java. Enables Java code to access

// the list of snippets to show on the NTP

class NTPSnippetsBridge : public ntp_snippets::NTPSnippetsServiceObserver {

public:

@@ -36,6 +36,7 @@ class NTPSnippetsBridge : public ntp_snippets::NTPSnippetsServiceObserver {

ntp_snippets::NTPSnippetsService* ntp_snippets_service_;

+ // Used to notify the Java side when new snippets have been fetched.

base::android::ScopedJavaGlobalRef<jobject> observer_;

ScopedObserver<ntp_snippets::NTPSnippetsService,

ntp_snippets::NTPSnippetsServiceObserver>

« no previous file with comments | « chrome/android/java_sources.gni ('k') | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('j') | no next file with comments »