chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java - Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java

Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address more comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java

index 669bdf1bc3cc7bce6c4b27b1aa6a36fcdf9fb0c3..25099d141ab03e8c5f79f294a99e1796ad86373a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java

@@ -20,7 +20,7 @@

private IncognitoNewTabPageManager mManager;

private boolean mFirstShow = true;

- private NewTabScrollView mScrollView;

+ private NewTabPageScrollView mScrollView;

private int mSnapshotWidth;

private int mSnapshotHeight;

@@ -49,7 +49,7 @@ public IncognitoNewTabPageView(Context context, AttributeSet attrs) {

protected void onFinishInflate() {

super.onFinishInflate();

- mScrollView = (NewTabScrollView) findViewById(R.id.ntp_scrollview);

+ mScrollView = (NewTabPageScrollView) findViewById(R.id.ntp_scrollview);

// FOCUS_BEFORE_DESCENDANTS is needed to support keyboard shortcuts. Otherwise, pressing

// any shortcut causes the UrlBar to be focused. See ViewRootImpl.leaveTouchMode().