chrome/android/java/res/layout/new_tab_page_incognito.xml - Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_incognito.xml

Issue 1833763002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address more comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/layout/new_tab_page.xml ('k') | chrome/android/java/res/layout/new_tab_page_layout.xml » ('j') | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <org.chromium.chrome.browser.ntp.IncognitoNewTabPageView	6 <org.chromium.chrome.browser.ntp.IncognitoNewTabPageView

7 xmlns:android="http://schemas.android.com/apk/res/android"	7 xmlns:android="http://schemas.android.com/apk/res/android"

8 xmlns:chrome="http://schemas.android.com/apk/res-auto"	8 xmlns:chrome="http://schemas.android.com/apk/res-auto"

9 android:id="@+id/ntp_content"	9 android:id="@+id/ntp_content"

10 android:layout_width="match_parent"	10 android:layout_width="match_parent"

11 android:layout_height="match_parent"	11 android:layout_height="match_parent"

12 android:paddingTop="@dimen/tab_strip_height" >	12 android:paddingTop="@dimen/tab_strip_height" >

13	13

14 <org.chromium.chrome.browser.ntp.NewTabScrollView	14 <org.chromium.chrome.browser.ntp.NewTabPageScrollView

15 android:id="@+id/ntp_scrollview"	15 android:id="@+id/ntp_scrollview"

16 android:background="@color/ntp_bg_incognito"	16 android:background="@color/ntp_bg_incognito"

17 android:layout_width="match_parent"	17 android:layout_width="match_parent"

18 android:layout_height="match_parent"	18 android:layout_height="match_parent"

19 android:paddingTop="@dimen/toolbar_height_no_shadow"	19 android:paddingTop="@dimen/toolbar_height_no_shadow"

20 android:fadingEdgeLength="9dp"	20 android:fadingEdgeLength="9dp"

21 android:fillViewport="false"	21 android:fillViewport="false"

22 android:focusable="true"	22 android:focusable="true"

23 android:focusableInTouchMode="true"	23 android:focusableInTouchMode="true"

24 android:requiresFadingEdge="vertical"	24 android:requiresFadingEdge="vertical"

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71 android:focusable="true"	71 android:focusable="true"

72 android:fontFamily="sans-serif-medium"	72 android:fontFamily="sans-serif-medium"

73 android:padding="16dp"	73 android:padding="16dp"

74 android:text="@string/learn_more"	74 android:text="@string/learn_more"

75 android:textAllCaps="true"	75 android:textAllCaps="true"

76 android:textColor="#03a9f4"	76 android:textColor="#03a9f4"

77 android:textSize="14sp" />	77 android:textSize="14sp" />

78	78

79 </LinearLayout>	79 </LinearLayout>

80	80

81 </org.chromium.chrome.browser.ntp.NewTabScrollView>	81 </org.chromium.chrome.browser.ntp.NewTabPageScrollView>

82	82

83 </org.chromium.chrome.browser.ntp.IncognitoNewTabPageView>	83 </org.chromium.chrome.browser.ntp.IncognitoNewTabPageView>

OLD	NEW