Resynthesize _DeferredClassElement instead of actual ClassElementImpl.

Resynthesize _DeferredClassElement instead of actual ClassElementImpl.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/c1f3689736a9c47ddddbb501f5193f39f5066385

[Paul Berry, 2016-03-24 19:40:14]

lgtm

https://codereview.chromium.org/1833743002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/1833743002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:1085: if (type is
ClassElementImpl) {
Nit: it's not obvious without reading the rest of the CL why this change is
necessary, which makes me worry that when someone comes back to maintain this
code later they'll be confused.

Consider changing to "if (type is! DeferredClassElement)"

so that if someone comes across this code later they can just navigate to
DeferredClassElement and figure out what is going on.

https://codereview.chromium.org/1833743002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1833743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:648: * The class element that has
been resynthesized from a summary.  The actual
s/The class element/A class element/

https://codereview.chromium.org/1833743002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:1461: * TODO(scheglov) inline?
AFAIK, the VM is smart about inlining methods like this one, since there is no
polymorphism involved.

[scheglov, 2016-03-24 19:56:49]

Description was changed from

==========
Resynthesize _DeferredClassElement instead of actual ClassElementImpl.

R=paulberry@google.com
BUG=
==========

to

==========
Resynthesize _DeferredClassElement instead of actual ClassElementImpl.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/c1f3689736a9c47ddddbb501f5193f39f5066385
==========

[scheglov, 2016-03-24 19:56:51]

Committed patchset #1 (id:1) manually as
c1f3689736a9c47ddddbb501f5193f39f5066385 (presubmit successful).