Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1833733002: Add explicit dependency on //url in remoting/base (Closed)

Created:
4 years, 9 months ago by Sergey Ulanov
Modified:
4 years, 9 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add explicit dependency on //url in remoting/base remoting_base uses GURL, but didn't have explicit dependency on //url. BUG=597559 TBR=lambroslambrou@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/b54d090e99cea7a3043eebe7b66cbb1e1761f72b

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M remoting/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Sergey Ulanov
4 years, 9 months ago (2016-03-24 18:57:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833733002/20001
4 years, 9 months ago (2016-03-24 18:59:54 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b54d090e99cea7a3043eebe7b66cbb1e1761f72b Cr-Commit-Position: refs/heads/master@{#383114}
4 years, 9 months ago (2016-03-24 19:14:43 UTC) #6
Sergey Ulanov
4 years, 9 months ago (2016-03-24 19:15:31 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) manually as
b54d090e99cea7a3043eebe7b66cbb1e1761f72b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698