Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: tests/language/logical_expression2_test.dart

Issue 183373003: Revert "Fix bad type-inferrence for logical expressions." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/logical_expression2_test.dart
diff --git a/tests/language/logical_expression2_test.dart b/tests/language/logical_expression2_test.dart
deleted file mode 100644
index 7d6ddd5244ba88d1381dc6a840d347ff8bb0049c..0000000000000000000000000000000000000000
--- a/tests/language/logical_expression2_test.dart
+++ /dev/null
@@ -1,31 +0,0 @@
-// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import "package:expect/expect.dart";
-
-// Regression test for issue 17149.
-
-int globalCounter = 0;
-
-void nonInlinedUse(Object object) {
- if (new DateTime.now().millisecondsSinceEpoch == 42) nonInlinedUse(object);
- if (object is! String) globalCounter++;
-}
-
-int confuse(x) {
- if (new DateTime.now().millisecondsSinceEpoch == 42) return confuse(x - 1);
- return x;
-}
-
-main() {
- var o = [ "foo", 499 ][confuse(1)];
-
- // The `o is String` check in the rhs of the logical or must not be
- // propagated to the `if` body.
- if ((o is num) ||
- (o is String && true)) {
- nonInlinedUse(o);
- }
- Expect.equals(1, globalCounter);
-}
« no previous file with comments | « tests/compiler/dart2js/simple_inferrer_and_or_test.dart ('k') | tests/language/logical_expression3_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698