Added custom bindings for renamed custom functions.

Added custom bindings for renamed custom functions.

BUG=
R=blois@google.com

Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=1296

[Emily Fortuna, 2013-07-08 22:48:20]

This is a two part CL. The corresponding Dart change is found at
https://codereview.chromium.org/18850007.

https://codereview.chromium.org/18337011/diff/1/Source/bindings/dart/custom/D...
File Source/bindings/dart/custom/DartFormDataCustom.cpp (right):

https://codereview.chromium.org/18337011/diff/1/Source/bindings/dart/custom/D...
Source/bindings/dart/custom/DartFormDataCustom.cpp:94: DartStringAdapter name =
DartUtilities::dartToStringWithNullCheck(Dart_GetNativeArgument(args, 1),
exception);
these files don't seem to follow the 80 char convention. but I can break them if
preferred.

[blois, 2013-07-08 23:09:30]

https://codereview.chromium.org/18337011/diff/1/Source/bindings/dart/custom/D...
File Source/bindings/dart/custom/DartFormDataCustom.cpp (right):

https://codereview.chromium.org/18337011/diff/1/Source/bindings/dart/custom/D...
Source/bindings/dart/custom/DartFormDataCustom.cpp:77: receiver->append(name,
filename);
Isn't it:
append(String name, String value)
append(String name, Blob value, String filename)?

If so, then:
DartStringAdapter value =
DartUtilities::dartToStringWithNullCheck(Dart_GetNativeArgument(args, 2),
exception);
...
receiver->append(name, value);

https://codereview.chromium.org/18337011/diff/1/Source/bindings/dart/custom/D...
Source/bindings/dart/custom/DartFormDataCustom.cpp:94: DartStringAdapter name =
DartUtilities::dartToStringWithNullCheck(Dart_GetNativeArgument(args, 1),
exception);
On 2013/07/08 22:48:20, Emily Fortuna wrote:
> these files don't seem to follow the 80 char convention. but I can break them
if
> preferred.

Blink does not abide by the 80 char rule.

[Emily Fortuna, 2013-07-08 23:17:14]

PTAL.

[Anton Muhin, 2013-07-09 10:00:08]

https://codereview.chromium.org/18337011/diff/5001/Source/bindings/dart/custo...
File Source/bindings/dart/custom/DartFormDataCustom.cpp (right):

https://codereview.chromium.org/18337011/diff/5001/Source/bindings/dart/custo...
Source/bindings/dart/custom/DartFormDataCustom.cpp:73: DartStringAdapter value =
DartUtilities::dartToStringWithNullCheck(valueHandle, exception);
The code looks pretty much regular now, cannot it be autogenerated?

https://codereview.chromium.org/18337011/diff/5001/Source/bindings/dart/custo...
File Source/bindings/dart/custom/DartWebSocketCustom.cpp (right):

https://codereview.chromium.org/18337011/diff/5001/Source/bindings/dart/custo...
Source/bindings/dart/custom/DartWebSocketCustom.cpp:111: void
sendTypeDataCallback(Dart_NativeArguments args)
TypeData or Type[d]Data?

and again, looks pretty much regular.

[Emily Fortuna, 2013-07-09 17:14:01]

https://codereview.chromium.org/18337011/diff/5001/Source/bindings/dart/custo...
File Source/bindings/dart/custom/DartFormDataCustom.cpp (right):

https://codereview.chromium.org/18337011/diff/5001/Source/bindings/dart/custo...
Source/bindings/dart/custom/DartFormDataCustom.cpp:73: DartStringAdapter value =
DartUtilities::dartToStringWithNullCheck(valueHandle, exception);
On 2013/07/09 10:00:09, Anton Muhin wrote:
> The code looks pretty much regular now, cannot it be autogenerated?

The reason it can't be autogenerated is we've marked these functions as "custom"
because we changed the return type from the original IDL. Otherwise, yes, they
are pretty straightforward.

https://codereview.chromium.org/18337011/diff/5001/Source/bindings/dart/custo...
File Source/bindings/dart/custom/DartWebSocketCustom.cpp (right):

https://codereview.chromium.org/18337011/diff/5001/Source/bindings/dart/custo...
Source/bindings/dart/custom/DartWebSocketCustom.cpp:111: void
sendTypeDataCallback(Dart_NativeArguments args)
On 2013/07/09 10:00:09, Anton Muhin wrote:
> TypeData or Type[d]Data?
> 
> and again, looks pretty much regular.

oops, yes I fixed this locally on my computer but forgot to upload the change.
It's been updated to TypedData.

[blois, 2013-07-09 17:18:21]

lgtm

[Emily Fortuna, 2013-07-09 17:22:42]

Committed patchset #3 manually as r1296 (presubmit successful).