Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1833673003: [CacheStorage] Notify QuotaManager when a cache is in use (Closed)

Created:
4 years, 9 months ago by jkarlin
Modified:
4 years, 8 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Notify QuotaManager when a cache is in use This CL informs the QuotaManager when a cache for an origin is open so that it doesn't get deleted while in use. BUG=581709 Committed: https://crrev.com/d4939fa3fd2dd0b1314527d0b6173f10d2ac8360 Cr-Commit-Position: refs/heads/master@{#384253}

Patch Set 1 #

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/browser/cache_storage/cache_storage_cache.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
jkarlin
michaeln@ PTAL One concern I have with this CL is that it might lead to ...
4 years, 9 months ago (2016-03-24 16:52:57 UTC) #2
jkarlin
michaeln@, Ping!
4 years, 8 months ago (2016-03-28 17:55:42 UTC) #4
michaeln
lgtm
4 years, 8 months ago (2016-03-31 00:29:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833673003/20001
4 years, 8 months ago (2016-03-31 11:20:31 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 12:19:21 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 12:20:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4939fa3fd2dd0b1314527d0b6173f10d2ac8360
Cr-Commit-Position: refs/heads/master@{#384253}

Powered by Google App Engine
This is Rietveld 408576698