third_party/WebKit/Source/core/editing/EditingTestBase.h - Issue 1833653002: Move LayoutObject::nextOffset/previousOffset() to editing utility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingTestBase.h

Issue 1833653002: Move LayoutObject::nextOffset/previousOffset() to editing utility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingTestBase.cpp » ('j') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingTestBase.h

diff --git a/third_party/WebKit/Source/core/editing/EditingTestBase.h b/third_party/WebKit/Source/core/editing/EditingTestBase.h

index 8fe6d8345cf41ac15c6e24b44a21233cb64b238c..fd237d48127d4e4701fa6b36586b22900643c081 100644

--- a/third_party/WebKit/Source/core/editing/EditingTestBase.h

+++ b/third_party/WebKit/Source/core/editing/EditingTestBase.h

@@ -26,7 +26,7 @@ protected:

static PassRefPtrWillBeRawPtr<ShadowRoot> createShadowRootForElementWithIDAndSetInnerHTML(TreeScope&, const char* hostElementID, const char* shadowRootContent);

- void setBodyContent(const char*);

+ void setBodyContent(const std::string&);

yosin_UTC9 2016/03/25 04:13:30 Good! (^_^)b BTW, I'm not sure why PRESUBMIT comp

Seigo Nonaka 2016/03/25 05:11:21 Yeah, it doesn't warn about it. Fixed by adding in

PassRefPtrWillBeRawPtr<ShadowRoot> setShadowContent(const char* shadowContent, const char* shadowHostId);

void updateLayoutAndStyleForPainting();

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/EditingTestBase.cpp » ('j') | third_party/WebKit/Source/core/editing/EditingUtilities.cpp » ('J')