Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8655)

Unified Diff: chrome/test/data/webui/settings/appearance_browsertest.js

Issue 1833613002: MD Settings: fix improper use of prefs in tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/on_startup_browsertest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/appearance_browsertest.js
diff --git a/chrome/test/data/webui/settings/appearance_browsertest.js b/chrome/test/data/webui/settings/appearance_browsertest.js
index cbe61e4cfc8205c8d27aa6e6cd63ec8c08225102..3c3e17a34fee8d5c3ba76a202f894fc4d3b529f9 100644
--- a/chrome/test/data/webui/settings/appearance_browsertest.js
+++ b/chrome/test/data/webui/settings/appearance_browsertest.js
@@ -42,20 +42,10 @@ TEST_F('AppearanceSettingsBrowserTest', 'uiTests', function() {
};
suite('AppearanceHandler', function() {
- var fakePrefs = [{
- key: 'webkit.webprefs.default_font_size',
- type: chrome.settingsPrivate.PrefType.NUMBER,
- value: 1234,
- }];
-
suiteSetup(function() {
settingsPrefs = document.querySelector(
'cr-settings').$$('settings-prefs');
assertTrue(!!settingsPrefs);
- CrSettingsPrefs.resetForTesting();
- settingsPrefs.resetForTesting();
- var fakeApi = new settings.FakeSettingsPrivate(fakePrefs);
- settingsPrefs.initializeForTesting(fakeApi);
return CrSettingsPrefs.initialized;
});
@@ -76,7 +66,7 @@ TEST_F('AppearanceSettingsBrowserTest', 'uiTests', function() {
*/
test('custom font size', function() {
settingsPrefs.set(
- 'prefs.webkit.webprefs.default_font_size', 19);
+ 'prefs.webkit.webprefs.default_font_size.value', 19);
assertEquals('Custom', fontSize());
});
});
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/on_startup_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698