Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 18336002: Test that profiler is stopped when isolate is being disposed (Closed)

Created:
7 years, 5 months ago by yurys
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow, Yang, loislo
CC:
v8-dev, alph
Visibility:
Public.

Description

Test that profiler is stopped when isolate is being disposed The only way to get v8::CpuProfiler instance in the V8 public API is to call v8::Iolate::GetCpuProfiler(). The method will return NULL if the isolate has not been initialized yet or has been torn down already. It is the client's reponsibility to make sure that CPU profiling has been stopped before disposing of the isolate. This CL adds a test for this and several ASSRTS enforcing that assumptions. This allowed to be sure that heap is always setup when CPU profiling is being started. Based on that the number of places where already compiled functions are reported to the profiler event processor boils down to the single place (CpuProfiler::StartProcessorIfNotStarted). I'm going to rely on this assumption in further changes. BUG=None R=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15415

Patch Set 1 #

Patch Set 2 : Updated v8.h comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -11 lines) Patch
M include/v8.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/cpu-profiler.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 5 months ago (2013-07-01 08:23:43 UTC) #1
loislo
lgtm
7 years, 5 months ago (2013-07-01 08:29:19 UTC) #2
Yang
On 2013/07/01 08:29:19, loislo wrote: > lgtm LGTM.
7 years, 5 months ago (2013-07-01 12:26:14 UTC) #3
yurys
7 years, 5 months ago (2013-07-01 12:33:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698