Distinguish SimpleIdentifier uses and declarations at parse time.

pkg/analyzer/lib/dart/ast/ast.dart

Index: pkg/analyzer/lib/dart/ast/ast.dart
diff --git a/pkg/analyzer/lib/dart/ast/ast.dart b/pkg/analyzer/lib/dart/ast/ast.dart
index e53a2048d61dbdc961ea5096523a4550894a5dd1..ebe80aedaa95997a3b4360482a0b71f48328dce9 100644
--- a/pkg/analyzer/lib/dart/ast/ast.dart
+++ b/pkg/analyzer/lib/dart/ast/ast.dart
@@ -6704,7 +6704,10 @@ abstract class SimpleIdentifier extends Identifier {
   /**
    * Initialize a newly created identifier.
    */
-  factory SimpleIdentifier(Token token) = SimpleIdentifierImpl;
+  factory SimpleIdentifier(Token token, {bool isDeclaration: false}) {
+    if (isDeclaration) return new DeclaredSimpleIdentifier(token);

[Brian Wilkerson, 2016/03/25 15:37:31]

nit: block

[Bob Nystrom, 2016/03/28 16:09:16]

Haha, fixed. I swear one day I will remember to not do this.

+    return new SimpleIdentifierImpl(token);
+  }
 
   /**
    * Return the auxiliary elements associated with this identifier, or `null` if