Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: ipc/ipc_channel_proxy.cc

Issue 1833573002: Move TRACE_EVENT in IPC message dispatch to add message name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@only_thread_name
Patch Set: Remove patch deppendency. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/trace_event_args_whitelist.cc ('k') | ipc/ipc_message_templates.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_channel_proxy.cc
diff --git a/ipc/ipc_channel_proxy.cc b/ipc/ipc_channel_proxy.cc
index ab2672c44fcfb76a0b8fc3fa4b1cf7b473e99302..848e1856294f3d28384681f9c745a05add97e851 100644
--- a/ipc/ipc_channel_proxy.cc
+++ b/ipc/ipc_channel_proxy.cc
@@ -263,24 +263,13 @@ void ChannelProxy::Context::AddFilter(MessageFilter* filter) {
// Called on the listener's thread
void ChannelProxy::Context::OnDispatchMessage(const Message& message) {
-#if defined(IPC_MESSAGE_LOG_ENABLED)
- Logging* logger = Logging::GetInstance();
- std::string name;
- logger->GetMessageText(message.type(), &name, &message, NULL);
- TRACE_EVENT1("ipc", "ChannelProxy::Context::OnDispatchMessage",
- "name", name);
-#else
- TRACE_EVENT2("ipc", "ChannelProxy::Context::OnDispatchMessage",
- "class", IPC_MESSAGE_ID_CLASS(message.type()),
- "line", IPC_MESSAGE_ID_LINE(message.type()));
-#endif
-
if (!listener_)
return;
OnDispatchConnected();
#ifdef IPC_MESSAGE_LOG_ENABLED
+ Logging* logger = Logging::GetInstance();
if (message.type() == IPC_LOGGING_ID) {
logger->OnReceivedLoggingMessage(message);
return;
« no previous file with comments | « chrome/common/trace_event_args_whitelist.cc ('k') | ipc/ipc_message_templates.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698