Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1833563002: [V8] Removed debugger V8::PromiseEvent (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8] Removed debugger V8::PromiseEvent We decided to remove related devtools experiment. BUG=chromium:526811 LOG=Y R=yangguo@chromium.org Committed: https://crrev.com/725672512ad69befe75584852de57bd345ce063b Cr-Commit-Position: refs/heads/master@{#35275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -299 lines) Patch
M include/v8-debug.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/debug/debug.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/debug/debug.cc View 3 chunks +0 lines, -27 lines 0 comments Download
M src/debug/debug.js View 3 chunks +1 line, -36 lines 0 comments Download
M src/js/promise.js View 2 chunks +0 lines, -6 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D test/mjsunit/es6/debug-promises/events.js View 1 chunk +0 lines, -122 lines 0 comments Download
D test/mjsunit/es6/debug-promises/resolve-after-aborted-try-finally.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/mjsunit/es6/debug-promises/resolve-after-try-catch.js View 1 chunk +0 lines, -29 lines 0 comments Download
D test/mjsunit/es6/debug-promises/rethrow-in-try-finally.js View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
LGTM. Thanks for following up! We do still want promise rejection to trigger exception events, ...
4 years, 8 months ago (2016-03-29 12:31:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833563002/1
4 years, 8 months ago (2016-03-29 12:31:51 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/15652)
4 years, 8 months ago (2016-03-29 13:20:28 UTC) #5
Yang
On 2016/03/29 13:20:28, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 8 months ago (2016-04-05 14:30:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833563002/1
4 years, 8 months ago (2016-04-05 17:30:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 18:11:16 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 18:13:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/725672512ad69befe75584852de57bd345ce063b
Cr-Commit-Position: refs/heads/master@{#35275}

Powered by Google App Engine
This is Rietveld 408576698