Treat DownCastComposite as a StaticWarning, not a StaticTypeWarning.

Treat DownCastComposite as a StaticWarning, not a StaticTypeWarning.

This works around the fact that strong mode promotes all
StaticTypeWarnings to errors, but we don't want to do that for this
strong-mode-specific warning.

See: https://github.com/dart-lang/sdk/issues/26026

R=jmesserly@google.com, vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/8922198e78b37c9ebc2d9d7e8362a7dea139c4ce

[Bob Nystrom, 2016-03-23 21:22:07]

rnystrom@google.com changed reviewers:
+ jmesserly@google.com, vsm@google.com

[Bob Nystrom, 2016-03-23 21:22:07]

I'm not sure if this fix is sketchy our not, but it avoids DownCastComposite
ending up in the bucket of warnings that get promoted to errors.

What do you think?

[Jennifer Messerly, 2016-03-23 21:39:27]

lgtm

[vsm, 2016-03-23 21:41:51]

lgtm

[Bob Nystrom, 2016-03-23 22:36:03]

Description was changed from

==========
Treat DownCastComposite as a StaticWarning, not a StaticTypeWarning.

This works around the fact that strong mode promotes all
StaticTypeWarnings to errors, but we don't want to do that for this
strong-mode-specific warning.

See: https://github.com/dart-lang/sdk/issues/26026
==========

to

==========
Treat DownCastComposite as a StaticWarning, not a StaticTypeWarning.

This works around the fact that strong mode promotes all
StaticTypeWarnings to errors, but we don't want to do that for this
strong-mode-specific warning.

See: https://github.com/dart-lang/sdk/issues/26026

R=jmesserly@google.com, vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8922198e78b37c9ebc2d9d7e8362a7dea139c4ce
==========

[Bob Nystrom, 2016-03-23 22:36:04]

Committed patchset #1 (id:1) manually as
8922198e78b37c9ebc2d9d7e8362a7dea139c4ce (presubmit successful).