Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 18335008: Cleanup common POSIX functionality. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Cleanup common POSIX functionality. The Mutex implementation is the same for all 6 POSIX platformats, just like of them use the sched_yield() to implement Thread::YieldCPU(). R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15623

Patch Set 1 #

Patch Set 2 : Mark result as used #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -281 lines) Patch
M src/platform-cygwin.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +0 lines, -39 lines 2 comments Download
M src/platform-openbsd.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M src/platform-posix.cc View 1 2 chunks +53 lines, -0 lines 0 comments Download
M src/platform-solaris.cc View 2 chunks +0 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-11 09:27:37 UTC) #1
Dmitry Lomov (no reviews)
lgtm https://codereview.chromium.org/18335008/diff/2001/src/platform-macos.cc File src/platform-macos.cc (left): https://codereview.chromium.org/18335008/diff/2001/src/platform-macos.cc#oldcode666 src/platform-macos.cc:666: pthread_mutex_init(&mutex_, &attr); Hmm MacOS mutex did not have ...
7 years, 5 months ago (2013-07-11 10:52:15 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/18335008/diff/2001/src/platform-macos.cc File src/platform-macos.cc (left): https://codereview.chromium.org/18335008/diff/2001/src/platform-macos.cc#oldcode666 src/platform-macos.cc:666: pthread_mutex_init(&mutex_, &attr); On 2013/07/11 10:52:16, Dmitry Lomov (chromium) wrote: ...
7 years, 5 months ago (2013-07-11 10:58:45 UTC) #3
Benedikt Meurer
7 years, 5 months ago (2013-07-11 11:37:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15623 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698