third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp - Issue 1833493003: Remove ForceHorriblySlowRectMapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1833493003: Remove ForceHorriblySlowRectMapping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pi

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

index e5294b73ddbcbf4e736ab70286b6ded5453db3f1..1825e6748214c232116c389b1aec15614bd34bf7 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

@@ -365,10 +365,6 @@ void LayoutBoxModelObject::invalidateTreeIfNeeded(const PaintInvalidationState&

return;

LayoutRect previousPaintInvalidationRect = this->previousPaintInvalidationRect();

- // TODO(wangxianzhu): Enable this assert after we fix all paintInvalidationContainer mismatch issues. crbug.com/360286

- // ASSERT(&newPaintInvalidationState.paintInvalidationContainer() == &containerForPaintInvalidation());

Xianzhu 2016/03/29 23:05:24 It's enough to check this in LayoutObject::invalid

PaintInvalidationReason reason = invalidatePaintIfNeeded(newPaintInvalidationState);

clearPaintInvalidationFlags(newPaintInvalidationState);