mojom/mojom_parser/check_version.go - Issue 1833493002: Replace ErrorExit with log.Fatal in the mojom tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojom/mojom_parser/check_version.go

Issue 1833493002: Replace ErrorExit with log.Fatal in the mojom tool. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojom/mojom_parser/check_version.go

diff --git a/mojom/mojom_parser/check_version.go b/mojom/mojom_parser/check_version.go

index 69be835058afacbee90641655ef022febd0d5994..476f3f2b921c2c074736e3923089a200a2d31953 100644

--- a/mojom/mojom_parser/check_version.go

+++ b/mojom/mojom_parser/check_version.go

@@ -24,8 +24,6 @@ import (

// the comparison fails, an error message is logged and the program terminates

// with return code 1.

func checkVersion(args []string) {

- // TODO(azani): Move log.SetFlags to mojom_main.go when replacing ErrorExit with log.Fatalln.

- log.SetFlags(0)

mojomToolPath := args[0]

mojomDir := filepath.Dir(mojomToolPath)

sha1FilePath := filepath.Join(mojomDir, "mojom.sha1")