Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1833493002: Replace ErrorExit with log.Fatal in the mojom tool. (Closed)

Created:
4 years, 9 months ago by azani
Modified:
4 years, 9 months ago
Reviewers:
rudominer
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Replace ErrorExit with log.Fatal in the mojom tool. R=rudominer@chromium.org, rudominer BUG= Committed: https://chromium.googlesource.com/external/mojo/+/973baba085081c30c781984f1ce65fb26388136a

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M mojo/public/tools/bindings/mojom_tool/bin/linux64/mojom.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/mac64/mojom.sha1 View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojom/mojom_parser/check_version.go View 1 chunk +0 lines, -2 lines 0 comments Download
M mojom/mojom_parser/fmt_cmd.go View 3 chunks +4 lines, -3 lines 0 comments Download
M mojom/mojom_parser/mojom_main.go View 3 chunks +2 lines, -5 lines 0 comments Download
M mojom/mojom_parser/parse_cmd.go View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
azani
4 years, 9 months ago (2016-03-23 19:36:28 UTC) #1
rudominer
Does this have extraneous files in it too? https://codereview.chromium.org/1833493002/diff/1/mojom/mojom_parser/formatter/formatter_test.go File mojom/mojom_parser/formatter/formatter_test.go (right): https://codereview.chromium.org/1833493002/diff/1/mojom/mojom_parser/formatter/formatter_test.go#newcode113 mojom/mojom_parser/formatter/formatter_test.go:113: func ...
4 years, 9 months ago (2016-03-23 19:39:57 UTC) #2
azani
ptal https://codereview.chromium.org/1833493002/diff/1/mojom/mojom_parser/formatter/formatter_test.go File mojom/mojom_parser/formatter/formatter_test.go (right): https://codereview.chromium.org/1833493002/diff/1/mojom/mojom_parser/formatter/formatter_test.go#newcode113 mojom/mojom_parser/formatter/formatter_test.go:113: func TestFormatNoExtraFinalBlankLine(t *testing.T) { On 2016/03/23 19:39:57, rudominer ...
4 years, 9 months ago (2016-03-23 20:52:22 UTC) #3
rudominer
lgtm
4 years, 9 months ago (2016-03-23 20:55:10 UTC) #4
azani
4 years, 9 months ago (2016-03-23 21:00:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
973baba085081c30c781984f1ce65fb26388136a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698