Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 183343002: Move test_file_set to content/test/ (Closed)

Created:
6 years, 9 months ago by pilgrim_google
Modified:
6 years, 9 months ago
CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, dcheng, kinuko+watch
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : make names less generic #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : rebase, rename files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -193 lines) Patch
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 2 3 14 chunks +22 lines, -22 lines 0 comments Download
M content/browser/fileapi/dragged_file_util_unittest.cc View 1 2 3 12 chunks +24 lines, -24 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + content/test/fileapi_test_file_set.h View 1 2 3 2 chunks +13 lines, -15 lines 0 comments Download
A + content/test/fileapi_test_file_set.cc View 1 2 3 4 chunks +11 lines, -14 lines 0 comments Download
D webkit/browser/fileapi/test_file_set.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/browser/fileapi/test_file_set.cc View 1 chunk +0 lines, -70 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pilgrim_google
6 years, 9 months ago (2014-02-27 16:52:46 UTC) #1
jam
drive-by https://codereview.chromium.org/183343002/diff/1/content/test/test_file_set.h File content/test/test_file_set.h (right): https://codereview.chromium.org/183343002/diff/1/content/test/test_file_set.h#newcode1 content/test/test_file_set.h:1: // Copyright (c) 2012 The Chromium Authors. All ...
6 years, 9 months ago (2014-02-27 17:00:19 UTC) #2
ericu
https://codereview.chromium.org/183343002/diff/1/content/test/test_file_set.h File content/test/test_file_set.h (right): https://codereview.chromium.org/183343002/diff/1/content/test/test_file_set.h#newcode32 content/test/test_file_set.h:32: void SetUpOneTestCase(const base::FilePath& root_path, Once this is in the ...
6 years, 9 months ago (2014-02-27 18:27:20 UTC) #3
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 9 months ago (2014-03-03 15:32:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/183343002/40001
6 years, 9 months ago (2014-03-03 15:32:36 UTC) #5
jam
https://codereview.chromium.org/183343002/diff/40001/content/test/test_file_set.h File content/test/test_file_set.h (right): https://codereview.chromium.org/183343002/diff/40001/content/test/test_file_set.h#newcode5 content/test/test_file_set.h:5: #ifndef CONTENT_TEST_TEST_FILE_SET_H_ this file should be named something like ...
6 years, 9 months ago (2014-03-03 16:03:01 UTC) #6
jam
The CQ bit was unchecked by jam@chromium.org
6 years, 9 months ago (2014-03-03 16:03:17 UTC) #7
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 9 months ago (2014-03-04 17:20:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/183343002/60001
6 years, 9 months ago (2014-03-04 17:20:49 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 20:54:52 UTC) #10
Message was sent while issue was closed.
Change committed as 254816

Powered by Google App Engine
This is Rietveld 408576698