Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1833423003: [DevTools] Use plain text for network conditions menu. (Closed)

Created:
4 years, 8 months ago by dgozman
Modified:
4 years, 8 months ago
Reviewers:
paulirish, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Use plain text for network conditions menu. Fancy unicode symbols don't work on windows context menu. BUG=595247 Committed: https://crrev.com/c5a4252280d913211820b606c3e5bc6205a779dd Cr-Commit-Position: refs/heads/master@{#385022}

Patch Set 1 #

Patch Set 2 : addressed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/NetworkConditionsSelector.js View 1 4 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dgozman
This is going to M50.
4 years, 8 months ago (2016-03-28 21:49:10 UTC) #2
paulirish
Can we reformat these? The latency is the most important number. Commas also help my ...
4 years, 8 months ago (2016-03-28 22:16:51 UTC) #3
dgozman
On 2016/03/28 22:16:51, paulirish wrote: > Can we reformat these? The latency is the most ...
4 years, 8 months ago (2016-04-04 19:02:33 UTC) #4
paulirish
lgtm
4 years, 8 months ago (2016-04-04 19:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1833423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1833423003/20001
4 years, 8 months ago (2016-04-04 20:31:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 21:59:04 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 22:00:37 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c5a4252280d913211820b606c3e5bc6205a779dd
Cr-Commit-Position: refs/heads/master@{#385022}

Powered by Google App Engine
This is Rietveld 408576698