Linux status icon for Ubuntu Unity

ui/linux_ui/status_icon_linux.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_LINUX_UI_STATUS_ICON_LINUX_H_
+#define UI_LINUX_UI_STATUS_ICON_LINUX_H_
+
+#include "base/strings/string16.h"
+
+namespace gfx {
+class ImageSkia;
+}
+
+namespace ui {
+class MenuModel;
+}  // namespace ui
+
+// Since liblinux_ui cannot have dependencies on any chrome browser components
+// we cannot inherit from StatusIcon. So we implement the necessary methods
+// and let a wrapper class implement the StatusIcon interface and defer the
+// callbacks to a delegate.
+class StatusIconLinux {
+ public:
+  class Delegate {
+   public:
+    virtual void OnClick() = 0;
+  };

[sky, 2013/07/15 20:41:10]

Add a protected virtual destructor.

[sidharthms, 2013/07/16 01:12:05]

Done.

+
+  virtual ~StatusIconLinux() {}
+
+  virtual void SetImage(const gfx::ImageSkia& image) = 0;
+  virtual void SetPressedImage(const gfx::ImageSkia& image) = 0;
+  virtual void SetToolTip(const string16& tool_tip) = 0;
+  virtual void SetClickActionLabel(const string16& label) = 0;
+
+  // Invoked after a call to SetContextMenu() to let the platform-specific
+  // subclass update the native context menu based on the new model. If NULL is
+  // passed, subclass should destroy the native context menu.

[sky, 2013/07/15 20:41:10]

This comment isn't particularly clear. Doesn't the platform need to destroy the
menu regardless of what is passed in? Otherwise it could be referencing a
deleted MenuModel, right?

[sidharthms, 2013/07/16 01:12:05]

Done.

+  virtual void UpdatePlatformContextMenu(ui::MenuModel* model) = 0;
+
+  Delegate* delegate() { return delegate_; }
+  void set_delegate(Delegate* delegate) { delegate_ = delegate; }
+
+ private:
+  Delegate* delegate_;

[sky, 2013/07/15 20:41:10]

Constructor needs to initialize this to NULL.

[sidharthms, 2013/07/16 01:12:05]

Done.

+};
+
+#endif  // UI_LINUX_UI_STATUS_ICON_LINUX_H_