Issue 18334002: Remove SVGStyledLocatableElement class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18334002: Remove SVGStyledLocatableElement class (Closed)

Created:
7 years, 5 months ago by do-not-use

Modified:
7 years, 5 months ago

Reviewers:
Stephen Chennney, krit, pdr.

CC:
blink-reviews, pdr, f(malita), dglazkov+blink, eae+blinkwatch, Stephen Chennney, lgombos, haraken

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove SVGStyledLocatableElement class Remove SVGStyledLocatableElement class and have SVGGraphicsElement inherit SVGStyledElement directly instead. SVGStyledLocatableElement is no longer needed and according to the specification, SVGGraphicsElement should inherit SVGStyledElement (actually SVGElement once we merge SVGStyledElement into SVGElement). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153347

Patch Set 1 #

Patch Set 2 : Remove SVGElement::isStyledLocatable() #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -131 lines)			Patch
M	Source/core/core.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGElement.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGElement.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGGraphicsElement.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGGraphicsElement.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGLocatable.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
D	Source/core/svg/SVGStyledLocatableElement.h	View		1 chunk	+0 lines, -58 lines	0 comments	Download
D	Source/core/svg/SVGStyledLocatableElement.cpp	View		1 chunk	+0 lines, -59 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18334002/3001

7 years, 5 months ago (2013-07-01 13:31:01 UTC) #2

Message was sent while issue was closed.

Change committed as 153347

Expand Messages | Collapse Messages