DescriptionSpeed up interop patch file creation.
Made a number of optimizations to reduce load time from 8 secs to 1 sec. The changes involved:
- No longer dynamically generate patch files on startup for dart:* libraries (created from WebKits IDL e.g., html, svg, web_audio, web_gl, indexed_db, web_sql). Instead create a cache of patch files.
- Comparison of @JS refelctedType not by library and symbol name comparison.
- In addition, a VM mirror change see CL https://codereview.chromium.org/1834673003/ gives us the remaining speedup.
This cache of interop patch files, for Dartium only, requires a manual re-gen after go.sh run is:
> cd tools/dom/scripts
> run go.sh
The steps after (for Dartium) are:
1. build Dartium
2. cd tools/dartium
3. run generate_patches.sh
4. build Dartium
R=jacobr@google.com, alanknight@google.com
Committed: https://github.com/dart-lang/sdk/commit/10e70db01c98de3f426f07f000209d3f14328065
Patch Set 1 #Patch Set 2 : Added failure case #Patch Set 3 : cleanup #Patch Set 4 : cleanup #
Total comments: 2
Patch Set 5 : Incorporated Jacob's suggestions #Patch Set 6 : Requires latest change to WebKit #
Messages
Total messages: 6 (2 generated)
|