Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 183333005: [XHR] Reset m_downloadedBlobLength (Closed)

Created:
6 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
Visibility:
Public.

Description

[XHR] Reset m_downloadedBlobLength When XMLHttpRequest.responseType is specified to "blob", we download the resource into a file and on XMLHttpRequest.response call, we create a Blob object from m_response.downloadedFilePath() and m_downloadedBlobLength. m_downloadedBlobLength is accumulated on WebCore::XMLHttpRequest::didDownloadData() handler call but not reset on clearResponse() call. So, if you use the XHR instance again after calling open(), uncleared invalid size will be used. We should just reset it to 0 on clearResponse() call. BUG=349321 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -34 lines) Patch
M LayoutTests/http/tests/xmlhttprequest/response-blob-size.html View 1 chunk +25 lines, -31 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/response-blob-size-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 9 months ago (2014-03-05 04:47:11 UTC) #1
abarth-chromium
Can you add more of a description? Why do we need to reset m_downloadedBlobLength? What ...
6 years, 9 months ago (2014-03-05 05:26:38 UTC) #2
abarth-chromium
That actual change LGTM, but please improve the description before landing.
6 years, 9 months ago (2014-03-05 05:27:19 UTC) #3
tyoshino (SeeGerritForStatus)
Updated, sorry
6 years, 9 months ago (2014-03-05 05:28:43 UTC) #4
abarth-chromium
Perfect. Thanks!!
6 years, 9 months ago (2014-03-05 05:30:09 UTC) #5
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-05 05:31:07 UTC) #6
tyoshino (SeeGerritForStatus)
The CQ bit was unchecked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-05 05:31:27 UTC) #7
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-05 05:31:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/183333005/1
6 years, 9 months ago (2014-03-05 05:32:50 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 05:55:39 UTC) #10
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=17348
6 years, 9 months ago (2014-03-05 05:55:39 UTC) #11
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 9 months ago (2014-03-05 05:56:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/183333005/1
6 years, 9 months ago (2014-03-05 05:57:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/183333005/1
6 years, 9 months ago (2014-03-05 20:56:27 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 21:03:36 UTC) #15
Message was sent while issue was closed.
Change committed as 168531

Powered by Google App Engine
This is Rietveld 408576698