Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java

Issue 183333002: Cronet Java wrappers to fallback to HttpUrlConnection if Cronet is not available. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address formatting comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java
diff --git a/net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java b/net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java
index 8dab92ca2a58e1e06e9bc7026f8e4468b46718af..68d7b2c7cf83965a92a67ce8f415307bf133e301 100644
--- a/net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java
+++ b/net/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleUrlTest.java
@@ -12,53 +12,56 @@ import org.chromium.base.test.util.Feature;
* Example test that just starts the cronet sample.
*/
public class CronetSampleUrlTest extends CronetSampleTestBase {
- // URL used for base tests.
- private static final String URL = "http://127.0.0.1:8000";
-
- @SmallTest
- @Feature({"Main"})
- public void testLoadUrl() throws Exception {
- CronetSampleActivity activity = launchCronetSampleWithUrl(URL);
-
- // Make sure the activity was created as expected.
- assertNotNull(activity);
-
- waitForActiveShellToBeDoneLoading();
-
- // Make sure that the URL is set as expected.
- assertEquals(URL, activity.getUrl());
- assertEquals(200, activity.getHttpStatusCode());
- }
-
- @SmallTest
- @Feature({"Main"})
- public void testInvalidUrl() throws Exception {
- CronetSampleActivity activity = launchCronetSampleWithUrl("127.0.0.1:8000");
-
- // Make sure the activity was created as expected.
- assertNotNull(activity);
-
- waitForActiveShellToBeDoneLoading();
-
- // The load should fail.
- assertEquals(0, activity.getHttpStatusCode());
- }
-
- @SmallTest
- @Feature({"Main"})
- public void testPostData() throws Exception {
- String[] commandLineArgs = { CronetSampleActivity.POST_DATA_KEY, "test"};
- CronetSampleActivity activity =
- launchCronetSampleWithUrlAndCommandLineArgs(URL, commandLineArgs);
-
- // Make sure the activity was created as expected.
- assertNotNull(activity);
-
- waitForActiveShellToBeDoneLoading();
-
- // Make sure that the URL is set as expected.
- assertEquals(URL, activity.getUrl());
- // TODO(mef): The test server doesn't seem to work with chunked uploads.
- assertEquals(411, activity.getHttpStatusCode());
- }
+ // URL used for base tests.
+ private static final String URL = "http://127.0.0.1:8000";
+
+ @SmallTest
+ @Feature({"Main"})
+ public void testLoadUrl() throws Exception {
+ CronetSampleActivity activity = launchCronetSampleWithUrl(URL);
+
+ // Make sure the activity was created as expected.
+ assertNotNull(activity);
+
+ waitForActiveShellToBeDoneLoading();
+
+ // Make sure that the URL is set as expected.
+ assertEquals(URL, activity.getUrl());
+ assertEquals(200, activity.getHttpStatusCode());
+ }
+
+ @SmallTest
+ @Feature({"Main"})
+ public void testInvalidUrl() throws Exception {
+ CronetSampleActivity activity = launchCronetSampleWithUrl(
+ "127.0.0.1:8000");
+
+ // Make sure the activity was created as expected.
+ assertNotNull(activity);
+
+ waitForActiveShellToBeDoneLoading();
+
+ // The load should fail.
+ assertEquals(0, activity.getHttpStatusCode());
+ }
+
+ @SmallTest
+ @Feature({"Main"})
+ public void testPostData() throws Exception {
+ String[] commandLineArgs = {
+ CronetSampleActivity.POST_DATA_KEY, "test" };
+ CronetSampleActivity activity =
+ launchCronetSampleWithUrlAndCommandLineArgs(URL,
+ commandLineArgs);
+
+ // Make sure the activity was created as expected.
+ assertNotNull(activity);
+
+ waitForActiveShellToBeDoneLoading();
+
+ // Make sure that the URL is set as expected.
+ assertEquals(URL, activity.getUrl());
+ // TODO(mef): The test server doesn't seem to work with chunked uploads.
+ assertEquals(411, activity.getHttpStatusCode());
+ }
}

Powered by Google App Engine
This is Rietveld 408576698