Cronet Java wrappers to fallback to HttpUrlConnection if Cronet is not available.

base/android/java/src/org/chromium/base/UsedByReflection.java

+// Copyright 2014 The Chromium Authors. All rights reserved.

[mmenke, 2014/03/07 17:02:39]

Should again maintain the copyright years on these.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.base;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Target;
+
+/**
+ * Annotation used for marking methods and fields that are called by reflection. Useful for keeping
+ * components that would otherwise be removed by Proguard. Use the value parameter to mention a file

[mmenke, 2014/03/07 17:02:39]

nit:  Fix indent.

+ * that calls this method.
+ *
+ * Note that adding this annotation to a method is not enough to guarantee that
+ * it is kept - either its class must be referenced elsewhere in the program, or
+ * the class must be annotated with this as well.
+ *
+ * Usage example:<br />
+ *  {@code
+ *  @UsedByReflection("PeopleListItemView.java")
+    public PeopleListItemViewV11(Context context) {
+        super(context);
+    }
+    }
+

[mmenke, 2014/03/07 17:02:39]

This comment is practically illegible.

[mmenke, 2014/03/07 20:47:28]

To clarify:  A bunch of lines are missing asterisks, it uses a random HTML line
break, and it's not consistently indented.  Even if all that were fixed, I'd
probably have no idea what it means, of course.

[Charles, 2014/03/07 21:31:15]

You can actually get rid of these annotations, chromium has its own that serve
the same purpose (configuring proguard)

On 2014/03/07 20:47:28, mmenke wrote:

+ */
+@Target({
+    ElementType.METHOD,
+    ElementType.FIELD,
+    ElementType.TYPE,
+    ElementType.CONSTRUCTOR})
+public @interface UsedByReflection {

[mef, 2014/03/07 20:54:12]

The |UsedByReflection| annotation has not been used in Chromium before.
Dmitry, do you know whether it is necessary (I did find that it doesn't work
without it), and whether it could be replaced by some other annotation like
|UsedByNative|
(https://code.google.com/p/chromium/codesearch#chromium/src/base/android/java/...

[Charles, 2014/03/07 21:31:15]

These should probably be replaced by Chromium's proguard annotations.

On 2014/03/07 20:54:12, mef wrote:

+    String value();
+}