Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: third_party/WebKit/Source/core/html/HTMLImageLoader.cpp

Issue 1833303002: [Not committed] Make image load completion async and remove EventSender from ImageLoader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Loader_asyncImageLoadEvent_1
Patch Set: cleanup, fix new layout tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp b/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
index 48aa8328d212f03833ad1b68bc9bbb1db4b6b6c0..d0d05b7b4bce7698a8d293c34b28a925fc15709a 100644
--- a/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLImageLoader.cpp
@@ -73,11 +73,9 @@ void HTMLImageLoader::noImageResourceToLoad()
loadFallbackContentForElement(element());
}
-void HTMLImageLoader::notifyFinished(Resource*)
+void HTMLImageLoader::finishInternal(ImageResource* cachedImage)
{
- ImageResource* cachedImage = image();
RefPtrWillBeRawPtr<Element> element = this->element();
- ImageLoader::notifyFinished(cachedImage);
bool loadError = cachedImage->errorOccurred();
if (isHTMLImageElement(*element)) {

Powered by Google App Engine
This is Rietveld 408576698