third_party/WebKit/Source/core/dom/Document.cpp - Issue 1833303002: [Not committed] Make image load completion async and remove EventSender from ImageLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1833303002: [Not committed] Make image load completion async and remove EventSender from ImageLoader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Loader_asyncImageLoadEvent_1

Patch Set: cleanup, fix new layout tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/canvas/image-svg-intrinsic-size.html ('k') | third_party/WebKit/Source/core/html/HTMLImageLoader.h » ('j') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index 3ae652d4a77fd109b1f91e9e93388b5ee049fd44..331d705a4ce681dc859c2047e6b5e392bfc49bea 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -181,7 +181,6 @@

#include "core/loader/FrameFetchContext.h"

#include "core/loader/FrameLoader.h"

#include "core/loader/FrameLoaderClient.h"

-#include "core/loader/ImageLoader.h"

#include "core/loader/NavigationScheduler.h"

#include "core/loader/appcache/ApplicationCacheHost.h"

#include "core/origin_trials/DocumentOriginTrialContext.h"

@@ -2662,9 +2661,6 @@ void Document::implicitClose()

detachParser();

if (frame() && frame()->script().canExecuteScripts(NotAboutToExecuteScript)) {

- ImageLoader::dispatchPendingLoadEvents();

- ImageLoader::dispatchPendingErrorEvents();

HTMLLinkElement::dispatchPendingLoadEvents();

HTMLStyleElement::dispatchPendingLoadEvents();

}