third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html - Issue 1833303002: [Not committed] Make image load completion async and remove EventSender from ImageLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html

Issue 1833303002: [Not committed] Make image load completion async and remove EventSender from ImageLoader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Loader_asyncImageLoadEvent_1

Patch Set: cleanup, fix new layout tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/loading/onload/onload-image-data-png.html » ('j') | third_party/WebKit/Source/core/loader/ImageLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html b/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html

index 851733635dd90bd483c8478e419e55d35963d1fb..4fa3946ef5e3b16f99d8b049b7fb304a1308404a 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html

+++ b/third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html

@@ -18,6 +18,7 @@ bgctx.fillStyle = 'green';

bgctx.fillRect(0, 0, bgcanvas.width, bgcanvas.height);

var greenSquareURL = bgcanvas.toDataURL();

var img = new Image();

+img.onload = imgLoaded;

img.src = greenSquareURL;

var ctx1 = canvas1.getContext('2d');

var ctx2 = canvas2.getContext('2d');

@@ -36,15 +37,17 @@ ctx1.drawImage(bgcanvas, -100, 0, 200, 200, -25, 175, 100, 100);

ctx1.drawImage(bgcanvas, 0, 0, 100, 200, 75, 175, 100, 100);

ctx1.drawImage(bgcanvas, 0, 0, 200, 200, 175, 175, 100, 100);

-ctx2.drawImage(img, -100, -100, 300, 300, -25, -25, 300, 300);

-ctx2.drawImage(img, -100, -100, 200, 200, -25, -25, 100, 100);

-ctx2.drawImage(img, 0, -100, 100, 200, 75, -25, 100, 100);

-ctx2.drawImage(img, 0, -100, 200, 200, 175, -25, 100, 100);

-ctx2.drawImage(img, -100, 0, 200, 100, -25, 75, 100, 100);

-ctx2.drawImage(img, 0, 0, 200, 100, 175, 75, 100, 100);

-ctx2.drawImage(img, -100, 0, 200, 200, -25, 175, 100, 100);

-ctx2.drawImage(img, 0, 0, 100, 200, 75, 175, 100, 100);

-ctx2.drawImage(img, 0, 0, 200, 200, 175, 175, 100, 100);

+function imgLoaded() {

+ ctx2.drawImage(img, -100, -100, 300, 300, -25, -25, 300, 300);

+ ctx2.drawImage(img, -100, -100, 200, 200, -25, -25, 100, 100);

+ ctx2.drawImage(img, 0, -100, 100, 200, 75, -25, 100, 100);

+ ctx2.drawImage(img, 0, -100, 200, 200, 175, -25, 100, 100);

+ ctx2.drawImage(img, -100, 0, 200, 100, -25, 75, 100, 100);

+ ctx2.drawImage(img, 0, 0, 200, 100, 175, 75, 100, 100);

+ ctx2.drawImage(img, -100, 0, 200, 200, -25, 175, 100, 100);

+ ctx2.drawImage(img, 0, 0, 100, 200, 75, 175, 100, 100);

+ ctx2.drawImage(img, 0, 0, 200, 200, 175, 175, 100, 100);

if (window.testRunner) {

testRunner.waitUntilDone();