x64 support for d-to-i (truncated)

test/cctest/test-code-stubs-x64.cc

+// Copyright 2013 the V8 project authors. All rights reserved.
+// Rrdistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Rrdistributions of source code must retain the above copyright
+//       notice, this list of conditions and the following disclaimer.
+//     * Rrdistributions in binary form must reproduce the above
+//       copyright notice, this list of conditions and the following
+//       disclaimer in the documentation and/or other materials provided
+//       with the distribution.
+//     * Neither the name of Google Inc. nor the names of its
+//       contributors may be used to endorse or promote products derived
+//       from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+#include <stdlib.h>
+
+#include "v8.h"
+
+#include "cctest.h"
+#include "code-stubs.h"
+#include "test-code-stubs.h"
+#include "factory.h"
+#include "macro-assembler.h"
+#include "platform.h"
+
+using namespace v8::internal;
+
+
+#define __ assm.
+
+ConvertDToIFunc MakeConvertDToIFuncTrampoline(Isolate* isolate,
+                                              Register source_reg,
+                                              Register destination_reg) {
+  // Allocate an executable page of memory.
+  size_t actual_size;
+  byte* buffer = static_cast<byte*>(OS::Allocate(Assembler::kMinimalBufferSize,
+                                                   &actual_size,
+                                                   true));
+  CHECK(buffer);
+  HandleScope handles(isolate);
+  MacroAssembler assm(isolate, buffer, static_cast<int>(actual_size));
+  assm.set_allow_stub_calls(false);
+  int offset =
+    source_reg.is(rsp) ? 0 : (HeapNumber::kValueOffset - kSmiTagSize);
+  DoubleToIStub stub(source_reg, destination_reg, offset, true);
+  byte* start = stub.GetCode(isolate)->instruction_start();
+
+  __ push(rbx);
+  __ push(rcx);
+  __ push(rdx);
+  __ push(rsi);
+  __ push(rdi);
+
+  if (!source_reg.is(rsp)) {
+    __ lea(source_reg, MemOperand(rsp, -8 * kPointerSize - offset));
+  }
+
+  int param_offset = 7 * kPointerSize;
+  // Save registers make sure they don't get clobbered.
+  int reg_num = 0;
+  for (;reg_num < Register::NumAllocatableRegisters(); ++reg_num) {
+    Register reg = Register::from_code(reg_num);
+    if (!reg.is(rsp) && !reg.is(rbp) && !reg.is(destination_reg)) {
+      __ push(reg);
+      param_offset += kPointerSize;
+    }
+  }
+
+  // Re-push the double argument
+  __ subq(rsp, Immediate(kDoubleSize));
+  __ movsd(MemOperand(rsp, 0), xmm0);
+
+  // Call through to the actual stub
+  __ Call(start, RelocInfo::EXTERNAL_REFERENCE);
+
+  __ addq(rsp, Immediate(kDoubleSize));
+
+  // Make sure no registers have been unexpectedly clobbered
+  for (--reg_num; reg_num >= 0; --reg_num) {
+    Register reg = Register::from_code(reg_num);
+    if (!reg.is(rsp) && !reg.is(rbp) && !reg.is(destination_reg)) {
+      __ cmpq(reg, MemOperand(rsp, 0));
+      __ Assert(equal, "register was clobbered");
+      __ addq(rsp, Immediate(kPointerSize));
+    }
+  }
+
+  __ movq(rax, destination_reg);
+
+  __ pop(rdi);
+  __ pop(rsi);
+  __ pop(rdx);
+  __ pop(rcx);
+  __ pop(rbx);
+
+  __ ret(0);
+
+  CodeDesc desc;
+  assm.GetCode(&desc);
+  return reinterpret_cast<ConvertDToIFunc>(
+      reinterpret_cast<intptr_t>(buffer));
+}
+
+#undef __
+
+
+static Isolate* GetIsolateFrom(LocalContext* context) {
+  return reinterpret_cast<Isolate*>((*context)->GetIsolate());
+}
+
+
+TEST(ConvertDToI) {
+  CcTest::InitializeVM();
+  LocalContext context;
+  Isolate* isolate = GetIsolateFrom(&context);
+  HandleScope scope(isolate);
+
+#if DEBUG
+  // Verify that the tests actually work with the C version. In the release
+  // code, the compiler optimizes it away because it's all constant, but does it
+  // wrong, triggering an assert on gcc.
+  RunAllTruncationTests(&ConvertDToICVersion);
+#endif
+

[Yang, 2013/07/18 14:54:38]

Why not make it something like
Register source_registers[7] = {rsp, rax, rbx, rcx, rdx, rsi, rdi};
Register dest_registers[6] = {rax, rbx, rcx, rdx, rsi, rdi};

for (int s = 0; s < 7; s++) {
  for (int d = 0; d < 6; d++) {
    RunAllTruncationTests(
        MakeConvertDToIFuncTrampoline(isolate,
                                      source_registers[s],
                                      dest_registers[d]));
  }
}

+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsp, rax));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsp, rbx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsp, rcx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsp, rdx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsp, rdi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsp, rsi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rax, rax));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rax, rbx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rax, rcx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rax, rdx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rax, rdi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rax, rsi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rbx, rax));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rbx, rbx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rbx, rcx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rbx, rdx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rbx, rdi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rbx, rsi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rcx, rax));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rcx, rbx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rcx, rcx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rcx, rdx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rcx, rdi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rcx, rsi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdx, rax));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdx, rbx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdx, rcx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdx, rdx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdx, rdi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdx, rsi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsi, rax));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsi, rbx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsi, rcx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsi, rdx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsi, rdi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rsi, rsi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdi, rax));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdi, rbx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdi, rcx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdi, rdx));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdi, rdi));
+  RunAllTruncationTests(MakeConvertDToIFuncTrampoline(isolate, rdi, rsi));
+}