Correctly url-decode the path segment in the http_server.

pkg/http_server/lib/src/virtual_directory.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of http_server;
 
 /**
  * A [VirtualDirectory] can serve files and directory-listing from a root path,
  * to [HttpRequest]s.
  *
@@ skipping 57 matching lines @@
   Function _errorCallback;
   Function _dirCallback;
 
   _VirtualDirectory(this.root);
 
   void serve(Stream<HttpRequest> requests) {
     requests.listen(serveRequest);
   }
 
   void serveRequest(HttpRequest request) {
-    var path = new Path(request.uri.path).canonicalize();
+    var path = new Path(Uri.decodeComponent(request.uri.path)).canonicalize();

[Lasse Reichstein Nielsen, 2013/07/01 11:51:51]

I think this is wrong.
From the URI RFC: "A path consists of a sequence of path segments separated by a
slash ("/") character."
Here you are decoding "%2f" into "/" *before* deciding on where to split the
path segments. I think you do need to find the path-segments first, and then
decode each.

[Anders Johnsen, 2013/07/01 14:14:12]

Done.

 
     if (!path.isAbsolute) {
       return _serveErrorPage(HttpStatus.NOT_FOUND, request);
     }
 
     _locateResource(new Path('.'), path.segments())
         .then((entity) {
           if (entity == null) {
             _serveErrorPage(HttpStatus.NOT_FOUND, request);
             return;
@@ skipping 283 matching lines @@
 
   Future close() => new Future.value();
 
   void setMimeType(var bytes) {
     var mimeType = lookupMimeType(path, headerBytes: bytes);
     if (mimeType != null) {
       response.headers.contentType = ContentType.parse(mimeType);
     }
   }
 }