Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 18333002: Remove irrelevant parser test that has SVN issues. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Remove irrelevant parser test that has SVN issues. The file tests different CR and LF combinations that cannot be stored correctly in SVN. Since we do not need coverage here, we rather remove the test completely. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -64 lines) Patch
D test/webkit/parse-backslash-before-newline.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/webkit/parse-backslash-before-newline-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-01 08:10:19 UTC) #1
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-07-01 08:10:57 UTC) #2
Michael Achenbach
7 years, 5 months ago (2013-07-01 08:11:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15401 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698